Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16438 to 7.6: [Metricbeat] Change sqs metricset to use Average statistic method #16473

Merged
merged 3 commits into from
Feb 24, 2020
Merged

Cherry-pick #16438 to 7.6: [Metricbeat] Change sqs metricset to use Average statistic method #16473

merged 3 commits into from
Feb 24, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #16438 to 7.6 branch. Original message:

What does this PR do?

This PR is to change sqs metricset to use Average statistic method instead of Sum when querying CloudWatch metrics.
Related Discuss Forum Issue: https://discuss.elastic.co/t/metricbeat-aws-module-dashboard-not-working-and-aws-sqs-messages-visible-multiplied-by-5

This PR also fixed SQS dashboard to show last bucket with "drop_last_bucket":0. This case, when Metricbeat first started, dashboard will not be empty.

Why is it important?

Most of the metrics collected by CloudWatch regarding to SQS is more meaningful with average as statistic method. For example ApproximateAgeOfOldestMessage for the approximate age of the oldest non-deleted message in the queue, and ApproximateNumberOfMessagesVisible for the number of messages available for retrieval from the queue.

Screenshots

This is what I changed for each visualization in SQS dashboard to not drop the last bucket.
Screen Shot 2020-02-19 at 1 06 33 PM

…6438)

* Change sqs metricset to use Average statistic method

* re-export dashboard for sqs

* update changelog

* Add terms_field back into sqs visualizations

(cherry picked from commit 6076de6)
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@kaiyan-sheng kaiyan-sheng merged commit 1492b8c into elastic:7.6 Feb 24, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_16438_7.6 branch February 24, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants